Repository navigation
Conversation
After the Meade parser refactor, DEC targets and syncs were treated as degrees from the pole instead of celestial declination, and the longitude sign convention (east negative on the wire) was dropped.
|
Heads-up about a merge hazard rather than a review comment, since #304 touches the same thing. This and #304 shouldn't both land. #296 negates the longitude in Three other things for whoever picks a direction:
The getter-negation idea here is the right one and is what #304 does now, so credit where it's due if this ends up superseded. |
|
Closing — both fixes in this PR have now landed via the post-#291 repair series, and the diagnosis here was correct on both counts, including the longitude convention (which turned out to be the contested one).
The merged versions also distinguish the sub-degree cases ( |
After #291 the Meade DEC handlers stopped converting between celestial
declination and the internal "degrees from pole" representation. A goto
to +26 36'08" was treated as 26.6 from the pole instead of 63.4, so
the mount pointed at the wrong part of the sky, and every platesolve
sync made the error worse.
The same refactor dropped the sign handling for longitude on the Meade wire east is negative, but the mount stores cartographic longitude
(east positive). That gave a wrong LST for observers east of Greenwich